Skip to content

chore(jj): delete-pending bookmark fix/push-allow-new を forget - #60

Merged
aloekun merged 1 commit into
masterfrom
chore/forget-delete-pending-bookmark
Apr 19, 2026
Merged

chore(jj): delete-pending bookmark fix/push-allow-new を forget#60
aloekun merged 1 commit into
masterfrom
chore/forget-delete-pending-bookmark

Conversation

@aloekun

@aloekun aloekun commented Apr 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • local repo から delete-pending 状態の bookmark fix/push-allow-newjj bookmark forget で除去
  • docs/todo.md から完了タスク「7. 雑務: 過去の delete-pending bookmark cleanup」を削除

Context

jj git push --tracked 時に Refusing to push deleted bookmark fix/push-allow-new 警告が継続的に出ていた状態を解消。
remote bookmark 自体は触らず local tracking のみ停止するため安全 (jj bookmark forget の semantics)。

Verification

  • 実施前: jj bookmark listfix/push-allow-new (deleted) 表示
  • 実施後: master のみ表示、警告消失
  • pre-push-review APPROVED (1 iter, 1m 45s)

References

  • docs/todo.md task 7 (feedback_todo_no_history に従い完了タスク削除)

Summary by CodeRabbit

  • Documentation
    • ドキュメント内の完了済みタスクと関連する記載を整理・削除しました。

local repo から delete-pending 状態の bookmark `fix/push-allow-new` を
`jj bookmark forget` で除去し、`jj git push --tracked` 時の警告を消す。

## 実施内容

- `jj bookmark forget fix/push-allow-new` 実行 (remote は触らない)
- `docs/todo.md` から完了タスク「7. 雑務: 過去の delete-pending bookmark cleanup」を削除

## Verification

- 実施前: `jj bookmark list` に `fix/push-allow-new (deleted)` が表示
- 実施後: `master` のみ表示、警告消失

refs: docs/todo.md task 7 (feedback_todo_no_history 準拠で完了タスク削除)
@coderabbitai

coderabbitai Bot commented Apr 19, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6dfb4fc8-077e-4240-85e6-6a1eef62b40e

📥 Commits

Reviewing files that changed from the base of the PR and between 1331611 and 3c449a8.

📒 Files selected for processing (1)
  • docs/todo.md
💤 Files with no reviewable changes (1)
  • docs/todo.md

📝 Walkthrough

Walkthrough

docs/todo.md から「その他の進行中タスク」セクションとタスク #7(「雑務: 過去の delete-pending bookmark cleanup」)を削除し、jj bookmark forget の実行方針および現在地・詰まり情報を除去しました。

Changes

Cohort / File(s) Summary
Documentation Cleanup
docs/todo.md
「その他の進行中タスク」セクション、タスク #7、およびそれに関連する jj bookmark forget fix/push-allow-new の記載と状態情報(未対応/緊急性なし、詰まり:なし)を削除。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed プルリクエストのタイトルは、jj bookmark forget コマンドで delete-pending 状態の bookmark を除去するという、変更の主要な目的を明確に反映している。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aloekun
aloekun merged commit a20da9a into master Apr 19, 2026
1 check passed
@aloekun
aloekun deleted the chore/forget-delete-pending-bookmark branch April 19, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant