refactor(deploy): 出力先へのテンプレート配布を廃止

[aloekun]

Summary

• pnpm deploy:hooks で出力先プロジェクトに settings.local.json.template をコピーする処理を削除

Background

deploy-hooks.js はソース側のテンプレートを読み込んで {{PROJECT_DIR}} を置換し、settings.local.json を直接生成しています。出力先にテンプレートをコピーする処理はこの生成に使われておらず、不要でした。

配布物を exe + settings.local.json + hooks-config.toml の3種類に整理します。

Test plan

• pnpm deploy:hooks 実行後、出力先に settings.local.json.template がコピーされないこと
• 出力先に settings.local.json が正しく生成されること（hooks パス、permissions 保持）

🤖 Generated with Claude Code

Summary by CodeRabbit

リリースノート

• Chores
  • デプロイ設定の生成フローを改良しました。テンプレートを直接コピーせずに参照して生成するようになり、既存設定のマージ動作は維持されます。
  • テンプレートの解析エラー時に警告メッセージが表示され、該当ターゲットの処理を中断します。ログにエラー詳細が含まれます。

---

注: エンドユーザー向けの直接的な機能変更はありません。

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0f01a3d-3fff-4ddd-b53b-fa237735c5e4

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3dff4 and 9629eff.

📒 Files selected for processing (1)

• scripts/deploy-hooks.js

🚧 Files skipped from review as they are similar to previous changes (1)

• scripts/deploy-hooks.js

---

📝 Walkthrough

Walkthrough

scripts/deploy-hooks.jsのデプロイ処理が変更され、settings.local.json.templateを各ターゲットへ無条件でコピーする代わりにテンプレート内容を解決してsettings.local.jsonを生成・書き換える方式になりました。テンプレートのJSONパースエラーは警告表示してそのターゲット処理をスキップします。

Changes

Cohort / File(s)	Summary
Deploy hooks configuration scripts/deploy-hooks.js	テンプレートの無条件コピーを廃止。settings.local.json.templateを読み取り {{PROJECT_DIR}} を解決して JSON をパースし newSettings を生成。既存の settings.local.json が有効JSONの場合は hooks フィールドのみ置換、無効JSONの場合は全体を再生成。テンプレートパース失敗時は警告ログを出して当該ターゲット処理を早期終了。ユーザ向けメッセージを更新。

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(hooks): Replace matcher追加 & deploy時のpermissions保持 #4: 同じ scripts/deploy-hooks.js に対しテンプレート解析と hooks マージ/置換のロジックを実装しており、コードレベルで直接関連。

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PRタイトルはテンプレート配布の廃止という変更内容と完全に関連しており、変更の主要な目的を明確に要約しています。

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (3)

scripts/deploy-hooks.js (3)

103-116: 既存設定ファイル解析エラーのログ出力を推奨

113行目の catch ブロックでエラー内容を破棄しています。デバッグ時に既存ファイルの何が問題だったか特定しやすくするため、エラーメッセージをログ出力すると有用です。

🔍 デバッグ情報追加案

-      } catch {
+      } catch (e) {
         fs.writeFileSync(settingsDest, JSON.stringify(newSettings, null, 2) + "\n");
-        console.log("  WARN: existing settings.local.json was invalid, regenerated");
+        console.log(`  WARN: existing settings.local.json was invalid (${e.message}), regenerated`);
       }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/deploy-hooks.js` around lines 103 - 116, The catch block that handles
JSON.parse failures for settingsDest currently swallows the exception; update
the catch to accept the error (e.g., catch (err)) and log the error details
(using console.error or processLogger.error) along with context (settingsDest
and that regeneration is happening) before calling
fs.writeFileSync(newSettings...). Modify the catch around
JSON.parse/fs.readFileSync in the block that references settingsDest, parsed,
existing, and newSettings so the error message is preserved for debugging.

---

82-100: テンプレート解析失敗時のエラーハンドリング追加を推奨

90行目の JSON.parse(resolved) でテンプレートが不正な JSON の場合、例外がスローされますが、try-catch で囲まれていません。テンプレートファイルの編集ミス等でデプロイ全体が中断する可能性があります。

🛡️ エラーハンドリング追加案

   const templateSrc = path.join(CLAUDE_DIR, SETTINGS_TEMPLATE);
   if (fs.existsSync(templateSrc)) {
     const template = fs.readFileSync(templateSrc, "utf8");
     const resolved = template.replace(
       /\{\{PROJECT_DIR\}\}/g,
       targetDir.replace(/\\/g, "\\\\")
     );
-    const newSettings = JSON.parse(resolved);
+    let newSettings;
+    try {
+      newSettings = JSON.parse(resolved);
+    } catch (e) {
+      console.log(`  WARN: Failed to parse ${SETTINGS_TEMPLATE}: ${e.message}`);
+      return true;
+    }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/deploy-hooks.js` around lines 82 - 100, JSON.parse(resolved) can
throw on malformed JSON; wrap the parse (and subsequent validation of
newSettings) in a try-catch around where templateSrc/template and resolved are
used, catch the error, log a clear message including templateSrc and the parse
error, and either throw a new Error with contextual information or gracefully
skip updating hooks (depending on desired behavior) so the deploy doesn't crash;
ensure you reference the same variables (templateSrc, resolved, newSettings) and
preserve the existing validation of newSettings.hooks inside the try block.

---

7-7: ヘッダーコメントとコードの動作が不一致

コメントでは「hooks-config.toml が存在しない場合のみ、テンプレートをコピー」と記載されていますが、実際のコード（71-80行目）ではコピー処理は行われず、メッセージを出力するのみです。PR の趣旨に合わせてコメントを修正することを推奨します。

📝 修正案

 *   1. deploy-targets.json からターゲットプロジェクト一覧を読み込み
 *   2. 各ターゲットの .claude/ ディレクトリに exe をコピー
-*   3. hooks-config.toml が存在しない場合のみ、テンプレートをコピー
+*   3. settings.local.json.template を解決して settings.local.json を生成
+*   4. hooks-config.toml が存在しない場合は作成を促すメッセージを表示

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/deploy-hooks.js` at line 7, The header comment claiming "copy
template only if hooks-config.toml is missing" is out of sync with the actual
behavior (the code currently only logs a message when hooks-config.toml is
missing); update the header comment to accurately state that the script only
reports the missing file instead of copying, or if the original intent was to
perform the copy, implement the copy logic where the script checks for
"hooks-config.toml" and uses the fs copy methods to copy the template into place
and log success/failure; locate the missing-file handling block (the code that
prints the message about hooks-config.toml) and either change the comment above
it to reflect the current behavior or add the copy implementation and
corresponding logs so the comment remains accurate.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@scripts/deploy-hooks.js`:
- Around line 103-116: The catch block that handles JSON.parse failures for
settingsDest currently swallows the exception; update the catch to accept the
error (e.g., catch (err)) and log the error details (using console.error or
processLogger.error) along with context (settingsDest and that regeneration is
happening) before calling fs.writeFileSync(newSettings...). Modify the catch
around JSON.parse/fs.readFileSync in the block that references settingsDest,
parsed, existing, and newSettings so the error message is preserved for
debugging.
- Around line 82-100: JSON.parse(resolved) can throw on malformed JSON; wrap the
parse (and subsequent validation of newSettings) in a try-catch around where
templateSrc/template and resolved are used, catch the error, log a clear message
including templateSrc and the parse error, and either throw a new Error with
contextual information or gracefully skip updating hooks (depending on desired
behavior) so the deploy doesn't crash; ensure you reference the same variables
(templateSrc, resolved, newSettings) and preserve the existing validation of
newSettings.hooks inside the try block.
- Line 7: The header comment claiming "copy template only if hooks-config.toml
is missing" is out of sync with the actual behavior (the code currently only
logs a message when hooks-config.toml is missing); update the header comment to
accurately state that the script only reports the missing file instead of
copying, or if the original intent was to perform the copy, implement the copy
logic where the script checks for "hooks-config.toml" and uses the fs copy
methods to copy the template into place and log success/failure; locate the
missing-file handling block (the code that prints the message about
hooks-config.toml) and either change the comment above it to reflect the current
behavior or add the copy implementation and corresponding logs so the comment
remains accurate.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd18910d-b5c8-4e45-8a6f-aa74a47bc3bf

📥 Commits

Reviewing files that changed from the base of the PR and between ca357ac and 8e3dff4.

📒 Files selected for processing (1)

• scripts/deploy-hooks.js