fix(permissions): cli-pr-monitor --monitor-only を allow に追加し監視 wakeup の都度確認を解消 - #229
Merged
Conversation
… の都度確認を解消 問題: .claude/settings.json の ask に広域 `Bash(*cli-pr-monitor.exe*)` があり、read-only な `cli-pr-monitor.exe --monitor-only` (CI/CodeRabbit 状態を見るだけの監視チェック) まで都度 許可確認が出ていた。post-PR monitor (ADR-018) は park + CronCreate wakeup で自動定期監視する 設計だが、毎 wakeup の監視コマンドが確認待ちで停止し、自動化が機能していなかった。 修正: - allow に `Bash(*cli-pr-monitor.exe* --monitor-only)` を追加 (read-only 監視のみ許可。末尾に wildcard を置かず追加引数を弾く = `--monitor-only --mark-notified` 等で run_mark_notified() に dispatch される state 変更経路を防ぐ、pre-push security review 所見対応) - ask から広域 `Bash(*cli-pr-monitor.exe*)` を削除 (ask > allow の precedence のため、 広域 ask を残すと allow が効かない) security 根拠: - `--monitor-only` は外部に何も生成しない read-only (gh API で CI/CR 状態を取得するだけ) - PR 作成 (`pnpm create-pr`) / merge (`pnpm merge-pr` / `*cli-merge-pipeline.exe*`) は ask の まま維持 → 外部可視成果物の生成ゲート (ADR-028 趣旨) は温存 - = 過度に広い gate を read-only に厳密に絞る変更であり、外部可視操作の緩和ではない
📝 Walkthroughウォークスルー
変更内容Permissions設定変更
推定コードレビュー工数🎯 1 (Trivial) | ⏱️ ~2 minutes 関連する可能性のあるPR
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.claude/settings.json:
- Line 4: The allow pattern in the Claude settings does not match the actual
resume command, so monitoring restart will not be permitted. Update the Bash
allow entry in settings.json to match the top-level command string used by
RESUME_MONITORING_COMMAND, and verify it aligns with the real pnpm push
--monitor-only invocation rather than the cli-pr-monitor.exe wrapper.
- Around line 6-9: The ask gate in settings is missing direct invocations of
cli-pr-monitor.exe, so PR creation can bypass user prompting. Update the ask
entries in settings.json to also cover direct Bash calls to cli-pr-monitor.exe,
alongside the existing create-pr, merge-pr, and cli-merge-pipeline patterns, so
the default PR creation path in main.rs is always intercepted before running.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1a6137e4-f5ff-445c-98ab-b1b508573700
📒 Files selected for processing (1)
.claude/settings.json
aloekun
added a commit
that referenced
this pull request
Jul 1, 2026
… 分割 (PR-W3) (#230) * docs(todo): PR #229 post-merge-feedback T1-1/T2-1 採用 — tempfile mandate lint + 高並列 regression test を登録 (順位 236-237) * refactor(cli-merge-pipeline): feedback.rs + main.rs を 800 行以下に module 分割 (PR-W3) * docs: W3 split 反映 — plan status 更新 + feedback.rs → feedback/ 参照 broken link 修正 (adr-030 / plan / todo2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
問題: .claude/settings.json の ask に広域
Bash(*cli-pr-monitor.exe*)があり、read-only なcli-pr-monitor.exe --monitor-only(CI/CodeRabbit 状態を見るだけの監視チェック) まで都度許可確認が出ていた。post-PR monitor (ADR-018) は park + CronCreate wakeup で自動定期監視する
設計だが、毎 wakeup の監視コマンドが確認待ちで停止し、自動化が機能していなかった。
修正:
Bash(*cli-pr-monitor.exe* --monitor-only)を追加 (read-only 監視のみ許可。末尾にwildcard を置かず追加引数を弾く =
--monitor-only --mark-notified等で run_mark_notified()に dispatch される state 変更経路を防ぐ、pre-push security review 所見対応)
Bash(*cli-pr-monitor.exe*)を削除 (ask > allow の precedence のため、広域 ask を残すと allow が効かない)
security 根拠:
--monitor-onlyは外部に何も生成しない read-only (gh API で CI/CR 状態を取得するだけ)pnpm create-pr) / merge (pnpm merge-pr/*cli-merge-pipeline.exe*) は ask のまま維持 → 外部可視成果物の生成ゲート (ADR-028 趣旨) は温存
Summary by CodeRabbit