docs(linter): extensions 拡張時の test 追加 pattern を明文化 (順位 127) - #191
Merged
Conversation
CustomRuleTestCoverage の doc comment に、既存 rule の extensions を拡張した際に rule_test_coverage_check が要求するカバレッジ契約を満たす手順を追記。主要拡張子 / 非主要拡張子の分岐と、enforcing test (classify_rule_extensions / check_main_ext_coverage / check_other_ext_coverage / extract_existing_test_fn_names) の test location を正確に参照する。 着手フローに従い docs/claude-code-web-tasks.md の該当行を削除。
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthrough採用タスクテーブルから PR Changesドキュメント整備と仕様説明
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
docs/claude-code-web-tasks.mdの採用タスクから 順位 127 (T3, XS) を実行しました。採用タスク 3 件を調査した結果:
変更内容
src/hooks-post-tool-linter/src/main.rsのCustomRuleTestCoveragestruct doc comment に、既存 rule のextensionsを拡張した際の test 追加 pattern を明文化しました(純コメント追記のため Rust build / Windows hook 実行は成功条件にならず、Claude Code Web scope の判定基準を満たす)。要点(test location を正確に参照):
rs/toml/yaml/yml) →[rules.test_coverage.main_ext_tests.<ext>]に test 宣言が必須other_ext_testsに 1+ 宣言が必須main.rs走査で実在確認されるため、typo / 削除した test は orphan として検出される参照した enforcing test / helper(いずれも実在確認済み):
tests::rule_test_coverage_checktests::classify_rule_extensionstests::check_main_ext_coverage/tests::check_other_ext_coveragetests::extract_existing_test_fn_namestests::MAIN_EXTENSIONS着手フロー対応
着手フローに従い
docs/claude-code-web-tasks.mdの該当行を削除しました(todo-summary.md / todoN.md には ADR-033 の採番簡素化により当該エントリは既に存在せず)。https://claude.ai/code/session_0143vzZuBE6aRw1fXfkujzFD
Generated by Claude Code
Summary by CodeRabbit
リリースノート