Skip to content

ci: reword deep-review dedupe comment to match the relabel exception - #568

Merged
allxsmith merged 1 commit into
mainfrom
ci/439-deep-review-dedupe-comment
Aug 25, 2026
Merged

allxsmith merged 1 commit into
mainfrom
ci/439-deep-review-dedupe-comment

Conversation

@allxsmith

@allxsmith allxsmith commented Aug 25, 2026 •

Copy link
Copy Markdown
Owner

What

Comment-only change to .github/workflows/claude-review.yml. The security-posture paragraph in the header claimed the dedupe marker "caps usage at one review per PR ever — re-labeling never re-fires it", which the dedupe step's own EXCEPTION contradicts: a triage+-verified re-application of deep-review deliberately skips the probe and runs a fresh review (verified live on #417).

The reword states what the mechanism actually delivers: the cap applies to automatic usage, and a verified triage+ re-label is the one deliberate re-run path. Root CLAUDE.md already described this correctly; the workflow header was the stale copy.

Why it matters

This file gates who can spend opus usage, so its header carries more weight than average — and it reads top-down, so the wrong sentence lands before the correct EXCEPTION comment 80 lines later. Per the .github/CLAUDE.md review checklist, security comments must claim exactly what the mechanism delivers.

No triggers, permissions, allowlists, or step logic change — the diff touches # comment lines only.

Fixes #439

Summary by CodeRabbit

  • Documentation
    • Clarified that automatic deep reviews are limited to one per pull request.
    • Documented that verified triage users can re-run reviews by reapplying the deep-review label.

Copilot AI balanced review requested due to automatic review settings August 25, 2026 23:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The comment now accurately describes the existing workflow logic.

Pull request overview

Clarifies the deep-review workflow documentation to resolve #439 without changing workflow behavior.

Changes:

  • Documents the automatic review cap.
  • Identifies triage+ relabeling as the deliberate rerun path.
File summaries
File Description
.github/workflows/claude-review.yml Aligns the security header with the dedupe exception.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f6fa1ad6-0408-4e07-b053-cd6411b76e84

📥 Commits

Reviewing files that changed from the base of the PR and between 42816ef and 5c1920c.

📒 Files selected for processing (1)
  • .github/workflows/claude-review.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The workflow documentation now states that automatic deep reviews run once per pull request. It also documents the deliberate re-run path when a verified triage+ user reapplies the deep-review label.

Changes

Deep review documentation

Layer / File(s) Summary
Clarify review trigger rules
.github/workflows/claude-review.yml
The workflow comment distinguishes automatic deduplication from deliberate re-runs through the deep-review label.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5c192

This is a localized documentation-only workflow change with no trigger, permission, allowlist, or execution-logic changes; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the comment-only CI change and specifically identifies the deep-review deduplication exception.
Description check ✅ Passed The description clearly explains the change, rationale, affected workflow file, scope, and linked issue. It does not reproduce every template section, but it provides the critical information needed t…
Linked Issues check ✅ Passed The PR satisfies issue #439 by correcting the workflow header comment, documenting the verified triage+ re-label re-run path, preserving the automatic usage cap, and leaving workflow logic unchanged.
Out of Scope Changes check ✅ Passed The changes are limited to comment text in .github/workflows/claude-review.yml and directly support the linked issue. No unrelated workflow logic or configuration changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Description check

Explanation

The description clearly explains the change, rationale, affected workflow file, scope, and linked issue. It does not reproduce every template section, but it provides the critical information needed to review this small documentation-only change.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/439-deep-review-dedupe-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Preview Deployment

Preview URL: https://008ef220.bestax.pages.dev

@allxsmith allxsmith self-assigned this Aug 25, 2026
@allxsmith
allxsmith merged commit bec973b into main Aug 25, 2026
18 checks passed
@allxsmith
allxsmith deleted the ci/439-deep-review-dedupe-comment branch August 25, 2026 23:51
@bestax-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 5.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bestax-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bestax-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 2.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bestax-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] claude-review.yml comment contradicts its own dedupe code

2 participants