Repository navigation
ci: exempt triage+ collaborators from the ai-triage daily budget - #294
Merged
Merged
Conversation
Items opened by collaborators with triage access or higher always get auto-triage — the daily budget only meters outside authors. The bypass reuses the labeled path's live collaborators/permission check (the opened event's sender is the author), so stale associations can't skip the cap. Bot/claude-head/linked-PR skips still apply to everyone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pohc8xLkdx4gwXkW3xd7up
WalkthroughThe AI triage workflow now exempts items opened by triage-level collaborators from the daily budget after a live permission check. Inline workflow comments, repository guidance, and getting-started documentation describe the updated exemption rules. ChangesAI triage budget gating
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant OpenedEvent
participant AiTriageGate
participant CollaboratorAPI
participant BudgetCounter
OpenedEvent->>AiTriageGate: process opened item
AiTriageGate->>CollaboratorAPI: check sender collaborator role
CollaboratorAPI-->>AiTriageGate: return role
AiTriageGate->>BudgetCounter: charge outside-author item
Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Preview DeploymentPreview URL: https://3458c2da.bestax.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ai-triage.yml:
- Around line 18-21: Update the BUDGET explanatory comments and generated marker
text so the collaborator exemption is conditional: only successfully verified
triage+ collaborators bypass the cap, while permission lookup failures continue
through the budget path. Apply this wording consistently at the referenced
workflow sections.
In `@CLAUDE.md`:
- Around line 100-102: Update the AI_TRIAGE_MODE documentation to state that
items are uncapped only after a successful live triage+ collaborator role match;
permission-lookup failures must continue through the normal
AI_TRIAGE_DAILY_LIMIT budget path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 30984e0d-9ade-473b-987a-194550a34276
📒 Files selected for processing (3)
.github/workflows/ai-triage.ymlCLAUDE.mddocs/docs/guides/getting-started/ai-development.md
Comment on lines
+18
to
+21
| # BUDGET (auto runs by outside authors only; label runs are exempt — already | ||
| # human-metered by the click — and so are items opened by collaborators with | ||
| # triage+ access, verified live: trusted authors always get triage, the cap | ||
| # only meters strangers): a repo-wide daily counter kept as ONE marker comment on |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the collaborator exemption wording conditional.
Permission lookup failures intentionally fall through to the budget path, so these comments and the generated marker should say that successfully verified triage+ collaborators bypass the cap; they do not always bypass it.
Proposed wording
-# triage+ access, verified live: trusted authors always get triage, the cap
-# only meters strangers):
+# triage+ access when verified live; lookup failures use the budget path,
+# so the cap otherwise meters strangers):
-# always get triage — the budget only meters outside authors.
+# bypass the budget when the live role check succeeds; lookup failures
+# continue through the budget path.
- **AI triage budget**: ... Label-triggered runs and triage+ collaborators' items are exempt.
+ **AI triage budget**: ... Label-triggered runs and successfully verified triage+ collaborators' items are exempt; lookup failures use this budget path.Also applies to: 180-193, 231-231
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/ai-triage.yml around lines 18 - 21, Update the BUDGET
explanatory comments and generated marker text so the collaborator exemption is
conditional: only successfully verified triage+ collaborators bypass the cap,
while permission lookup failures continue through the budget path. Apply this
wording consistently at the referenced workflow sections.
Comment on lines
+100
to
+102
| issues/duplicates: automatic on new issues/PRs when `AI_TRIAGE_MODE=auto` (outside authors | ||
| capped at `AI_TRIAGE_DAILY_LIMIT`/day via a counter comment on issue #290; items opened by | ||
| triage+ collaborators are uncapped), or on demand via the label |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Document the permission-lookup fallback.
The workflow only bypasses the budget after a successful live role match; lookup failures follow the normal budget path. This text currently says all triage+ collaborator items are uncapped.
Proposed wording
- outside authors capped at `AI_TRIAGE_DAILY_LIMIT`/day via a counter comment on issue `#290`; items opened by
- triage+ collaborators are uncapped), or on demand via the label
+ outside authors capped at `AI_TRIAGE_DAILY_LIMIT`/day via a counter comment on issue `#290`;
+ successfully verified triage+ collaborators bypass the cap, while permission-lookup
+ failures use the budget path), or on demand via the label📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| issues/duplicates: automatic on new issues/PRs when `AI_TRIAGE_MODE=auto` (outside authors | |
| capped at `AI_TRIAGE_DAILY_LIMIT`/day via a counter comment on issue #290; items opened by | |
| triage+ collaborators are uncapped), or on demand via the label | |
| issues/duplicates: automatic on new issues/PRs when `AI_TRIAGE_MODE=auto` (outside authors | |
| capped at `AI_TRIAGE_DAILY_LIMIT`/day via a counter comment on issue `#290`; | |
| successfully verified triage+ collaborators bypass the cap, while permission-lookup | |
| failures use the budget path), or on demand via the label |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CLAUDE.md` around lines 100 - 102, Update the AI_TRIAGE_MODE documentation to
state that items are uncapped only after a successful live triage+ collaborator
role match; permission-lookup failures must continue through the normal
AI_TRIAGE_DAILY_LIMIT budget path.
Contributor
|
🎉 This PR is included in version 5.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Follow-up to #292: issues and PRs opened by collaborators with triage access or higher always get auto-triage — the
AI_TRIAGE_DAILY_LIMITbudget now only meters outside authors.@allxsmith/bestax-bulma)create-bestax)@allxsmith/bestax-docs) — ai-development guide.github/workflows/ai-triage.yml, rootCLAUDE.md)How: in the gate step's
openedpath, after the existing skips (bot authors,claude/*heads, PRs already carryingFixes #/Closes #— these still apply to everyone, since triage would be redundant regardless of author), the sender's live role is checked viarepos/{repo}/collaborators/{sender}/permission— the exact same check thelabeledpath already performs.admin|maintain|write|triage⇒ run triage without touching the budget counter; anyone else charges the daily budget as before.Security notes:
author_associationfrom the event payload — a revoked collaborator or a gameable "has one merged commit" association can never bypass the cap.openedevents the sender is the author, so this can't be confused with a third party's action.none⇒ the budget path — fail-closed, same idiom as the labeled gate.Related Issue(s)
Follow-up to #289 / #292.
Type of Change
Checklist
bash -nclean, prettier clean)CLAUDE.mdfiles are updatedAdditional Context
The budget marker comment's human-readable line now reads "Label-triggered runs and triage+ collaborators' items are exempt." No repo-variable changes needed — this works with the values already set.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pohc8xLkdx4gwXkW3xd7up
Generated by Claude Code
Summary by CodeRabbit
New Features
Documentation