Skip to content

ci: bestaxbot replies to a plain reviewer comment on its own PR - #254

Merged
allxsmith merged 1 commit into
mainfrom
claude/bestaxbot-reply
Jul 8, 2026
Merged

allxsmith merged 1 commit into
mainfrom
claude/bestaxbot-reply

Conversation

@allxsmith

@allxsmith allxsmith commented Jul 8, 2026 •

Copy link
Copy Markdown
Owner

Pull Request

Description

Broadens the bestaxbot-reply trigger so a trusted contributor's plain top-level comment on a bestaxbot-authored PR fires the reply job with no @bestaxbot mention required — the natural case of a reviewer talking on the bot's own PR. Mentions still work everywhere else, and a submitted review already needed no mention.

The issue_comment branch now fires when the author is OWNER/MEMBER/COLLABORATOR and either the body mentions @bestaxbot or the comment is on a PR (github.event.issue.pull_request set) whose author is bestaxbot. The existing github.event.sender.login != 'bestaxbot' self-exclusion becomes load-bearing here: it stops bestaxbot's own recap/reply comments on its PRs from re-triggering the job in a loop. Bot senders are already excluded by sender.type == 'User', so CodeRabbit/claude[bot]/github-actions comments never fire it.

  • bulma-ui (@allxsmith/bestax-bulma)
  • create-bestax (create-bestax)
  • docs (@allxsmith/bestax-docs)
  • Other: .github/workflows/bestaxbot-reply.yml (CI/automation)

Related Issue(s)

Refs #252

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Performance
  • Build tooling
  • Other (please describe):

Checklist

  • My code follows the project style guidelines
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have added/updated documentation as needed (in-file header + if: comments)
  • I have updated Storybook stories as needed (bulma-ui)
  • My changes require a change to the documentation
  • All new and existing tests passed
  • Any relevant dependencies are updated
  • If this PR changes commands, conventions, or package structure, the affected CLAUDE.md files are updated (n/a — no convention change)

Additional Context

Follow-up to #252. YAML validated locally. Workflow-only change; no package source touched.

🤖 Generated with Claude Code


Generated by Claude Code

Summary by CodeRabbit

  • New Features
    • Bestaxbot now responds to trusted top-level comments on its pull requests, even without a direct mention.
    • Comment-based automation on bestaxbot PRs is more flexible for approved contributors.
  • Bug Fixes
    • Improved handling of bot-triggered reply flows so valid comments are recognized more reliably.

A trusted contributor commenting on a bestaxbot-authored PR is talking to
the bot, so require no @bestaxbot mention there — fire the reply job when
issue.pull_request is set and the PR author is bestaxbot. Mentions still
work everywhere else; the sender-is-bestaxbot self-exclusion (now load-
bearing) stops its own recap/reply comments from looping.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NVR5yWevceZEFbTJmpviiM
@coderabbitai

coderabbitai Bot commented Jul 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 19dcb7e9-d6d1-4946-9684-0943e66ca21f

📥 Commits

Reviewing files that changed from the base of the PR and between 5f73642 and 690b2dd.

📒 Files selected for processing (1)
  • .github/workflows/bestaxbot-reply.yml

Walkthrough

The GitHub Actions workflow bestaxbot-reply.yml is updated to broaden the trigger condition for the respond job. Documentation comments and the job's if: condition are changed so trusted commenters' plain comments on bestaxbot-authored PRs trigger the job, not just @bestaxbot mentions or review submissions.

Changes

Workflow Trigger Update

Layer / File(s) Summary
Trusted comment trigger broadening
.github/workflows/bestaxbot-reply.yml
Documentation and gating comments are updated to describe the new trusted-trigger behavior, and the respond job's if: condition now triggers on trusted collaborators' comments on bestaxbot-authored PRs even without an @bestaxbot mention.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: github-actions, ci

Suggested reviewers: allxsmith

Poem

A rabbit hopped through YAML lines so neat,
Widening the trust that comments greet,
No mention needed, just a trusted voice,
On bestaxbot's PRs, now comments rejoice,
Hop, hop, the workflow's gate feels light and sweet.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the workflow-only change and highlights the main behavior update.
Description check ✅ Passed The description covers the change summary, affected area, issue reference, type of change, checklist, and additional context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/bestaxbot-reply

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Preview Deployment

Preview URL: https://faf6a903.bestax.pages.dev

@allxsmith
allxsmith merged commit 0d05554 into main Jul 8, 2026
11 checks passed
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bestax-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants