Repository navigation
ci: steer the implement agent to commit via git CLI, not the file-ops MCP - #250
Merged
Merged
Conversation
… MCP Implement run #18 fully built the Reveal component (gates green, 100% coverage) but produced no branch/PR: it reached for mcp__github_file_ops__commit_files, which is not allowlisted, and gave up blocked — even though the git-CLI commit/push verbs ARE allowlisted and are what runs #16/#17 used to open #243 and #247. Non-deterministic tool choice, same class as the fixer reaching for a nonexistent MCP reply tool. - Rewrite step 4 with an explicit git-CLI commit+push recipe (git checkout -b / add / commit / push) and state plainly that there is NO MCP commit tool here — git is already set up to SSH-sign as bestaxbot, so git-CLI commits come out Verified. - Add show_full_output so a blocked commit is visible in the log, not just an artifact the proxy won't let us download. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NVR5yWevceZEFbTJmpviiM
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThis PR modifies the Claude implementation GitHub Actions workflow, enabling ChangesClaude Implement Workflow Update
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Preview DeploymentPreview URL: https://5ad5a1fc.bestax.pages.dev |
Contributor
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 3.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
allxsmith
added a commit
that referenced
this pull request
Oct 10, 2026
The show_full_output comments in bestaxbot-reply, claude-implement and claude-pr-loop said the artifact's blob host was blocked by a proxy. No proxy sits in those jobs. The claim came from #250, where the proxy was the reader's, refusing the artifact download, and it predates the jobs going to block. claude-implement's upload has since succeeded at block through the agent's built-in entries, which skills-publish already cites. Each comment now says what is true of its own job: claude-implement and the loop's fix job upload the artifact, whose blob host needs no listing, and the log copy saves a download; bestaxbot-reply and the loop's verify job upload none, so the log is where the stream survives. The two upload-step comments no longer say the log carries only the init and final result, which stopped being true when show_full_output was added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give the implement agent an explicit git-CLI commit+push recipe and tell it there's no MCP commit tool, plus
show_full_output.Why
Implement run #18 fully built Reveal (gates green,
Reveal.tsx100% coverage) but opened no PR — its own finish comment said it was blocked:It reached for the file-ops MCP commit tool (not allowlisted) instead of the git CLI (
git add/commit/push, which is allowlisted and is exactly what runs #16/#17 used to open #243 and #247). Same non-deterministic tool-grab as the fixer reaching for a nonexistent MCP reply tool — and the same fix: steer it to the proven path explicitly.Changes
git checkout -b / add / commit / push -u origin HEADrecipe, and a plain statement thatmcp__github_file_ops__commit_filesis not allowlisted / will be denied. Git is already SSH-signing as bestaxbot, so git-CLI commits come out Verified.show_full_output: trueon the implement job — a blocked commit shows in the log (the artifact's blob host is proxy-blocked).Note
Prompt + one input. No allowlist/permission/model change (git verbs were already allowlisted; this just steers to them). YAML validated.
Generated by Claude Code
Summary by CodeRabbit