Skip to content

Fix plugins not showing up in Single Html mode #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anht3889
Copy link

@anht3889 anht3889 commented Nov 22, 2023

Context

Fix #2194

Root cause:
We're using Set<String> jsFiles. The Set interface does not provide any ordering guarantees. We should make sure APP_JS at the top of other scripts.

Solution:
Use LinkedHashSet instead to guarantee the js scripts ordering.

Checklist

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

@anht3889 anht3889 marked this pull request as draft November 22, 2023 06:47
@anht3889 anht3889 marked this pull request as ready for review November 22, 2023 06:47
@baev
Copy link
Member

baev commented Dec 1, 2023

@anht3889 thanks!

fixed via #2220

@baev baev closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Package" and "Behaviors" plugins not loaded in Single file report mode
3 participants