Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with pytest 8.1 #795

Merged
merged 7 commits into from
Mar 11, 2024
Merged

Fix compatibility with pytest 8.1 #795

merged 7 commits into from
Mar 11, 2024

Conversation

delatrie
Copy link
Contributor

@delatrie delatrie commented Mar 4, 2024

Context

The getfixturedefs call must be fixed to adapt to the recent changes introduced in pytest-dev/pytest#11785 (pytest 8.1.0+).
The changes are described here.

Note

The PR keeps the compatibility with older versions of pytest.

Fixes #794

@delatrie delatrie added bug Something isn't working theme:pytest labels Mar 4, 2024
@delatrie delatrie requested a review from skhomuti March 4, 2024 13:34
@delatrie delatrie marked this pull request as ready for review March 4, 2024 13:34
@Piwero
Copy link

Piwero commented Mar 4, 2024

Good finding and quick action. When is expected to be this released? I'm experiencing this error and just wondering if worth to downgrade pytest or waitining to to get the fix here. Thanks

@delatrie
Copy link
Contributor Author

delatrie commented Mar 4, 2024

pytest 8.1 has been yanked (see pytest-dev/pytest#12069). We'll wait until the release becomes available again.

@folt
Copy link

folt commented Mar 6, 2024

https://docs.pytest.org/en/stable/changelog.html#pytest-8-1-0-2024-03-03
seems to be an update in release

Out tests use pytest.Stash that requires pytest 7.0.
We can't test against pytest 6 until the pytest version of
the runner is decoupled with the one of the samples.
@delatrie delatrie merged commit 00591e1 into master Mar 11, 2024
17 checks passed
@delatrie delatrie deleted the pytest-8.1-compat-fix branch March 11, 2024 07:08
IvanBuruyane pushed a commit to IvanBuruyane/allure-python that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme:pytest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Latest pytest release (8.1.0) breaks allure_listener plugin
5 participants