feat: made TxDeposit's mint field non-optional#514
Merged
mattsse merged 6 commits intoalloy-rs:mainfrom May 23, 2025
Merged
Conversation
Rimeeeeee
requested review from
clabby,
emhane,
mattsse and
refcell
as code owners
mattsse
requested changes
May 8, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
great
maybe let's add a few rlp roundtrip tests as well
you can get raw deposit txs from basescan for example
the first tx in a block is awlays a deposit, for example:
https://basescan.org/getRawTx?tx=0xa68157af562dec44406bf9334381cf7e46aab0dd3f6495d99644e02b6fed6f09
mattsse
requested changes
May 8, 2025
mattsse
approved these changes
May 23, 2025
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
fixes #513 --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #513