Closed
Conversation
refcell
force-pushed
the
rf/feat/batch-type
branch
from
847b0ea to
3e88dcc
Compare
### Description > [!WARNING] > > Stacked ontop of #172 Adds the single batch to op-alloy-protocol.
clabby
reviewed
Oct 25, 2024
refcell
added
D-do-not-merge
Collaborator
Author
|
This PR is replaced by the stack started in #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kona-deriveis nearly decoupled from protocol-level types. The final remaining types are the batch types: single and span batches.This PR ports over all batch types from
kona-derive's batch module, introducing a new minimal trait abstraction for batch validity checks called theBatchValidator. Effectively, it is a subset of theL2ChainProvidertrait inkona-derive.Additional Context
Works on op-rs/kona#695