Conversation
refcell
force-pushed
the
refcell/re-exports
branch
from
d581e8a to
01e94e6
Compare
Member
|
versioned releases are out now and should prefer these |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since alloy dependencies are imported by github, versioning dependencies can get ugly downstream if a specific revision is imported.
To avoid dependency clashes, re-export necessary traits for downstream use. This allows crates and workspaces like kona to specify external dependency revisions (e.g. importing
alloy_eipswith a specific revision) while also importing theop-alloy-consensusonmainbranch along with it's EIP-2718 Encoding and Decoding traits, avoiding a dependency clash with thealloy_eipscrate.Example: op-rs/kona#267