refactor(block): expose executor tx result type#349
Merged
klkvr merged 1 commit intoApr 28, 2026
Conversation
Expose transaction execution result type on `BlockExecutorFactory`. Before this, `BlockExecutorFor` was fixing executor EVM, transaction and receipt types, but not `BlockExecutor::Result`. Because of that generic code could not name tx execution result type from factory-created executor. Now `BlockExecutorFor` also constrains `BlockExecutor::Result` via factory associated type, so downstream code can use this type without adding extra `BlockExecutor<Result = ...>` bound.
klkvr
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epose transaction execution result type on
BlockExecutorFactory.Before this,
BlockExecutorForwas fixing executor EVM, transaction andreceipt types, but not
BlockExecutor::Result. Because of that genericcode could not name tx execution result type from factory-created
executor.
Now
BlockExecutorForalso constrainsBlockExecutor::Resultviafactory associated type, so downstream code can use this type
without adding extra
BlockExecutor<Result = ...>bound.This is a part of type plumbing required for parallel execution, see paradigmxyz/reth#23759
Note
This is based off the latest released version, not main.