feat: complete migration to StateDB#236
Merged
klkvr merged 2 commits intoalloy-rs:mainfrom Feb 25, 2026
Merged
Conversation
0xForerunner
force-pushed
the
state-db
branch
from
3a49526 to
03928f0
Compare
Contributor
Author
|
@klkvr am I able to get a review here? |
klkvr
approved these changes
Feb 15, 2026
crates/op-evm/src/block/mod.rs
Outdated
| where | ||
| DB: Database + 'a, | ||
| I: Inspector<EvmF::Context<&'a mut State<DB>>> + 'a, | ||
| DB: Database + DatabaseCommit + StateDB + 'a, |
Member
There was a problem hiding this comment.
should both extra traits be supertraits of StateDB?
Contributor
Author
There was a problem hiding this comment.
I was prioritizing flexibility here. I wasn't 100% sure that all consumers would intend for all StateDB to also be DatabaseCommit.
Contributor
Author
There was a problem hiding this comment.
For my personal use case, I am okay with StateDB: DatabaseCommit + Database.
klkvr
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #234 for context
This PR completes the transition from the concrete
State<DB>toStateDB. We must introduce the fndrain_balancesto accomplish this. Bothdrain_balancesandincrement_balancesshould be implementable with DatabaseCommit + Database which is why I have this PR open in revm. If this is accepted then it should be possible to remove these methods. Alternatively,DatabaseCommitExtcould be moved here.PR Checklist