Skip to content

fix(BAL): Change StorageReads to U256 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rakita wants to merge 1 commit into from
Closed

fix(BAL): Change StorageReads to U256 #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/eip7928/src/account_changes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use crate::{
SlotChanges, balance_change::BalanceChange, code_change::CodeChange, nonce_change::NonceChange,
};
use alloc::vec::Vec;
use alloy_primitives::{Address, StorageKey};
use alloy_primitives::{Address, U256};

/// This struct is used to track the changes across accounts in a block.
#[derive(Debug, Clone, Default, PartialEq, Eq)]
Expand All @@ -21,7 +21,7 @@ pub struct AccountChanges {
/// List of slot changes for this account.
pub storage_changes: Vec<SlotChanges>,
/// List of storage reads for this account.
pub storage_reads: Vec<StorageKey>,
pub storage_reads: Vec<U256>,
/// List of balance changes for this account.
pub balance_changes: Vec<BalanceChange>,
/// List of nonce changes for this account.
Expand Down Expand Up @@ -69,7 +69,7 @@ impl AccountChanges {

/// Returns the storage reads for this account.
#[inline]
pub fn storage_reads(&self) -> &[StorageKey] {
pub fn storage_reads(&self) -> &[U256] {
&self.storage_reads
}

Expand Down Expand Up @@ -98,7 +98,7 @@ impl AccountChanges {
}

/// Add a storage read slot.
pub fn with_storage_read(mut self, key: StorageKey) -> Self {
pub fn with_storage_read(mut self, key: U256) -> Self {
self.storage_reads.push(key);
self
}
Expand Down Expand Up @@ -130,7 +130,7 @@ impl AccountChanges {
/// Add multiple storage reads at once.
pub fn extend_storage_reads<I>(mut self, iter: I) -> Self
where
I: IntoIterator<Item = StorageKey>,
I: IntoIterator<Item = U256>,
{
self.storage_reads.extend(iter);
self
Expand Down