migrate eip5792 and eip7547 from alloy repo to here #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pana
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
mattsse
reviewed
Feb 15, 2025
|
|
||
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true |
There was a problem hiding this comment.
this we can't do because now we need to vendor them individually so all of them must be assigned the current alloy version
|
|
||
| [dependencies] | ||
| alloy-primitives = { workspace = true, features = ["serde", "map"] } | ||
| alloy-serde.workspace = true |
There was a problem hiding this comment.
this we can't do,
or at leat we need extract the serde crate first:
There was a problem hiding this comment.
this is also problematic currently because this depends on alloy- crate as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all EIP-related crates to this repository for unified management.
These two crates will be removed from the Alloy repo after this PR is merged.
Motivation
Solution
PR Checklist