Conversation
prestwich
requested review from
DaniPopes,
gakonst and
mattsse
as code owners
mattsse
approved these changes
Oct 18, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
makes sense, this type should flatten and renaming seal -> hash is more useful
pending @DaniPopes
Member
Author
we can rename to hash if you'd prefer. right now it only allows that as a deser alias, while still producing seal during serialization This PR includes a serde helper mod for renaming to hash |
DaniPopes
approved these changes
Oct 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Was working on alloy-rs/alloy#1485 and it seemed like there were a few holes in the API
this is a breaking change as it flattens the serde object
Solution
PR Checklist