Merged
Conversation
DaniPopes
approved these changes
Mar 7, 2024
Member
DaniPopes
left a comment
DaniPopes
left a comment
There was a problem hiding this comment.
Looks fine, can you test by patching to this branch on your PR? There's a test in alloy-contract
DaniPopes
reviewed
Mar 7, 2024
| address: alloy_sol_types::private::Address, | ||
| provider: P, | ||
| network: ::core::marker::PhantomData<N>, | ||
| transport: ::core::marker::PhantomData<T>, |
Member
There was a problem hiding this comment.
should be one field and starting with underscore to silence unused warnings
Member
Author
I did! 😄 |
DaniPopes
approved these changes
Mar 7, 2024
Member
DaniPopes
left a comment
DaniPopes
left a comment
There was a problem hiding this comment.
great , thank u mr on bjerg
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
sol!needs to be adjusted to work with alloy-rs/alloy#190Solution
Adds network and transport generics to the generated code, which requires the new provider from alloy-rs/alloy#190
I'd like some extensive reviewing of this as I'm not too experienced with proc macros
PR Checklist