Skip to content

chore: make receipt generic #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 1 commit into from
Dec 16, 2025
Merged

chore: make receipt generic #3357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/rpc-types-eth/src/pubsub.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use alloy_serde::WithOtherFields;
#[derive(Clone, Debug, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(serde::Deserialize))]
#[cfg_attr(feature = "serde", serde(untagged))]
pub enum SubscriptionResult<T = Transaction> {
pub enum SubscriptionResult<T = Transaction, R = TransactionReceipt> {
/// New block header.
Header(Box<WithOtherFields<Header>>),
/// Log
Expand All @@ -21,7 +21,7 @@ pub enum SubscriptionResult<T = Transaction> {
/// SyncStatus
SyncState(PubSubSyncStatus),
/// Transaction Receipts
TransactionReceipts(Vec<TransactionReceipt>),
TransactionReceipts(Vec<R>),
}

/// Response type for a SyncStatus subscription.
Expand Down Expand Up @@ -52,9 +52,10 @@ pub struct SyncStatusMetadata {
}

#[cfg(feature = "serde")]
impl<T> serde::Serialize for SubscriptionResult<T>
impl<T, R> serde::Serialize for SubscriptionResult<T, R>
where
T: serde::Serialize,
R: serde::Serialize,
{
fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
where
Expand Down