Skip to content

feat: add transactionReceipts into SubscriptionKind#2974

Merged
mattsse merged 3 commits intoalloy-rs:mainfrom
10gic:add-transaction-receipts-into-subscription-kind
Dec 16, 2025
Merged

feat: add transactionReceipts into SubscriptionKind#2974
mattsse merged 3 commits intoalloy-rs:mainfrom
10gic:add-transaction-receipts-into-subscription-kind

Conversation

@10gic
Copy link
Copy Markdown
Contributor

@10gic 10gic commented Oct 3, 2025

Add transactionReceipts for receipts notification. For more information, see: ethereum/go-ethereum#32697

@10gic
Copy link
Copy Markdown
Contributor Author

10gic commented Oct 9, 2025

Hi @DaniPopes, @mattsse, @klkvr, hope you're doing well. When you have a chance, could you take a look at this PR? Any feedback would be great. Thanks!

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, supportive, just need to figure out how to roll this out without introducing breaking changes on reth

@mattsse mattsse added the blocked This cannot move forward until something else changes label Oct 15, 2025
Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm,

blocking this until next reth release

@github-project-automation github-project-automation bot moved this to Reviewed in Alloy Oct 15, 2025
@mattsse mattsse merged commit 8f789e2 into alloy-rs:main Dec 16, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in Alloy Dec 16, 2025
mattsse added a commit that referenced this pull request Dec 23, 2025
mattsse added a commit that referenced this pull request Dec 23, 2025
* Revert "chore: make receipt generic (#3357)"

This reverts commit 0abad60.

* Revert "feat: add `transactionReceipts` into SubscriptionKind (#2974)"

This reverts commit 8f789e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked This cannot move forward until something else changes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants