feat: add OptimismExecutionPayloadV3#242
Conversation
|
alloy project does not intend to house any non-Ethereum structs. this whole file belongs in a separate repo |
|
this should be in there for ease of use, at least for the time being because we already have some other op types, but once stable we should remove them yes |
| /// This structure maps on the ExecutionPayloadV3 structure of the beacon chain spec. | ||
| /// | ||
| /// See also: <https://github.com/ethereum/execution-apis/blob/6709c2a795b707202e93c4f2867fa0bf2640a84f/src/engine/shanghai.md#executionpayloadv2> | ||
| #[derive(Clone, Debug, PartialEq, Eq, Serialize, Deserialize)] |
There was a problem hiding this comment.
this should also reference the op spec:
There was a problem hiding this comment.
this should also reference the op spec:
sure, proposed here #244
mattsse
requested review from
DaniPopes,
Evalir,
gakonst and
prestwich
as code owners
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
lgtm codewise. as prestwich said, this should only be temporary—I think we should make an issue to track moving OP types to another repo once we have stability
|
@DaniPopes is the clippy relevant? otherwise good to merge |
|
@prestwich nope, clippy is unrelated—see proptest fix: proptest-rs/proptest#427 |
|
Tracking wrt OP types #243 |
Updates `alloy-rpc-types` and `alloy-rpc-trace-types` to `52bf7125d944e8a389371be503035724dfde5657`, which contains alloy-rs/alloy#242
Updates `alloy-rpc-types` and `alloy-rpc-trace-types` to `52bf7125d944e8a389371be503035724dfde5657`, which contains alloy-rs/alloy#242
Updates `alloy-rpc-types` and `alloy-rpc-trace-types` to `52bf7125d944e8a389371be503035724dfde5657`, which contains alloy-rs/alloy#242
4 participants
Motivation
Towards paradigmxyz/reth#6871
Solution
Adds specific type for
OptimismExecutionPayloadV3to be used inBuiltPayload. Very similar toExecutionPayloadV3, adds optimism-specific fieldparent_beacon_block_rootPR Checklist