Skip to content

feat: Rename alloy-providers to alloy-provider#205

Closed
moricho wants to merge 3 commits intoalloy-rs:mainfrom
moricho:rename-providers
Closed

feat: Rename alloy-providers to alloy-provider#205
moricho wants to merge 3 commits intoalloy-rs:mainfrom
moricho:rename-providers

Conversation

@moricho
Copy link
Contributor

@moricho moricho commented Feb 11, 2024

Motivation

Closes: #196

For consistency with the other crates such as alloy-signer, alloy-contract, ...

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@gakonst
Copy link
Member

gakonst commented Feb 15, 2024

holding off on this as there's conflicts

@moricho
Copy link
Contributor Author

moricho commented Feb 16, 2024

@gakonst Resolved the conflicts

@prestwich
Copy link
Member

I would prefer if this waited until after the open PR's are resolved

@moricho
Copy link
Contributor Author

moricho commented Feb 16, 2024

@prestwich Sure! I'll work on this again after that

@prestwich
Copy link
Member

thank you 🙏🙏

@onbjerg
Copy link
Member

onbjerg commented Mar 11, 2024

hi @moricho, #190 was merged which was the biggest blocker, I think you can start on this again, but I'd advise you to probably just open a new PR instead of trying to resolve the conflicts

@moricho
Copy link
Contributor Author

moricho commented Mar 12, 2024

Hi @onbjerg, thanks for letting me know. I've opened a new one instead of this 👉 #278

@onbjerg onbjerg closed this Mar 12, 2024
@moricho moricho deleted the rename-providers branch March 12, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Rename alloy-providers to alloy-provider

4 participants