Merged
Conversation
klkvr
requested review from
DaniPopes,
gakonst,
mattsse and
onbjerg
as code owners
mattsse
approved these changes
Dec 7, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I think this is fine, ideally this is something we only have to get right once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1712
Implements https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7691.md
Solution
The current API might be a bit confusing given that the fn has same signature as
eip4844::calc_blob_gasprice. Unsure how we can make this nicer, something similar toBaseFeeParamscould probably work but it's unclear how callers would set itAlso I don't not how we should handle this in
BlockHeader::next_block_blob_feeandBlobGasFiller. Given variable update fraction we no longer can estimate the blob fee for next block without knowing the hardfork activation timesPR Checklist