Conversation
klkvr
requested review from
DaniPopes,
emhane,
gakonst,
mattsse and
onbjerg
as code owners
prestwich
approved these changes
Oct 23, 2024
Member
|
yep this is a logic bug in #1528 😅
sidecar encoding on its own is defined, because RLP is well-defined for any set of RLP objects. It is not used anywhere that we're aware of #1528 (comment) |
mattsse
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right now this encodes as list and expects string during decoding which is incorrect.
I am wondering if we should remove those impls completely? Given that sidecar encoding on its own is not defined
Solution
PR Checklist