Skip to content

chore: remove 7685 request variants#1515

Merged
mattsse merged 3 commits intomainfrom
matt/remove-requests
Oct 18, 2024
Merged

chore: remove 7685 request variants#1515
mattsse merged 3 commits intomainfrom
matt/remove-requests

Conversation

@mattsse
Copy link
Copy Markdown
Member

@mattsse mattsse commented Oct 18, 2024

these got removed and replaced with a general purpose request blob

@mattsse mattsse force-pushed the matt/remove-requests branch from 35b78d5 to 9de3533 Compare October 18, 2024 18:22
Copy link
Copy Markdown
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also rm these:

pub struct WithdrawalRequest {
/// Address of the source of the exit.
pub source_address: Address,
/// Validator public key.
pub validator_pubkey: FixedBytes<48>,
/// Amount of withdrawn ether in gwei.
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))]
pub amount: u64,
}

pub struct ConsolidationRequest {
/// Source address
pub source_address: Address,
/// Source public key
pub source_pubkey: FixedBytes<48>,
/// Target public key
pub target_pubkey: FixedBytes<48>,
}

pub struct DepositRequest {
/// Validator public key
pub pubkey: FixedBytes<48>,
/// Withdrawal credentials
pub withdrawal_credentials: B256,
/// Amount of ether deposited in gwei
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))]
pub amount: u64,
/// Deposit signature
pub signature: FixedBytes<96>,
/// Deposit index
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))]
pub index: u64,
}

we just need the addresses + bytecode from these now, not even the request type constants, since this is determined by the position of the request in the Requests struct anyway

@mattsse mattsse force-pushed the matt/remove-requests branch from ded0bf4 to 4a99c06 Compare October 18, 2024 18:40
Comment thread crates/eips/src/eip7002.rs
Comment thread crates/eips/src/eip6110.rs
Comment thread crates/eips/src/eip7251.rs
@mattsse mattsse force-pushed the matt/remove-requests branch from 4a99c06 to c16027c Compare October 18, 2024 18:45
Copy link
Copy Markdown
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 86417bb into main Oct 18, 2024
@mattsse mattsse deleted the matt/remove-requests branch October 18, 2024 18:57
lwedge99 pushed a commit to sentioxyz/alloy that referenced this pull request Jan 3, 2025
* chore: remove 7685 request variants

* keep addresses and code

* fix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants