Conversation
klkvr
requested review from
DaniPopes,
emhane,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
klkvr
force-pushed
the
klkvr/fix-sim-json
branch
from
be76da3 to
073b8b5
Compare
mattsse
approved these changes
Sep 10, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* fix: serde for eth_simulateV1 * clippy + fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Updates serde for
eth_simulateV1to match JSON encoding in geth. ref ethereum/go-ethereum#27720There's another change for
BlockOverridesfields which I am not sure we should address now:Solution
PR Checklist