Skip to content

Conversation

@GAMMACASE
Copy link
Member

@GAMMACASE GAMMACASE commented Feb 3, 2023

This pr is WIP to track and test out things and might be appended with further fixes. If you know anything that was also updated, comment about that in here or commit it directly (if possible). Also please, keep all the discussions in the appropriate thread in the AM discord, thanks.

This pr is also a collaborative work of: databomb#6706, Digby ° ૩ °#4534, Poggu#5993, Yuera#5880, PixeL#1337, Keldra#1114 and many others from the AM discord.

@ddorab
Copy link

ddorab commented Feb 3, 2023

Please double check yourself as well but I think CheckWinLimit is \xA1\x2A\x2A\x2A\x2A\x55\x89\xE5\x56\x53\x3D\x2A\x2A\x2A\x2A\x0F\x84\x2A\x2A\x2A\x2A\x8B\x10\x8B\x52\x2A\x81\xFA\x2A\x2A\x2A\x2A\x0F\x85\x2A\x2A\x2A\x2A\x8B\x70\x2A

@ddorab
Copy link

ddorab commented Feb 3, 2023

SetModelClass \x55\x89\xE5\x56\x53\x83\xEC\x1C\x8B\x5D\x2A\x8B\x75\x2A\x8B\x03\x53\xFF\x90\x2A\x2A\x2A\x2A\x83\xC4\x10\x84\xC0 as well

@Poggicek
Copy link
Contributor

Poggicek commented Feb 3, 2023

Please double check yourself as well but I think CheckWinLimit is \xA1\x2A\x2A\x2A\x2A\x55\x89\xE5\x56\x53\x3D\x2A\x2A\x2A\x2A\x0F\x84\x2A\x2A\x2A\x2A\x8B\x10\x8B\x52\x2A\x81\xFA\x2A\x2A\x2A\x2A\x0F\x85\x2A\x2A\x2A\x2A\x8B\x70\x2A

Incorrect

@ddorab
Copy link

ddorab commented Feb 3, 2023

was that not the signature you sent?

@ddorab
Copy link

ddorab commented Feb 3, 2023

oh sorry, I thought I updated mine

@Poggicek
Copy link
Contributor

Poggicek commented Feb 3, 2023

SetModelClass \x55\x89\xE5\x56\x53\x83\xEC\x1C\x8B\x5D\x2A\x8B\x75\x2A\x8B\x03\x53\xFF\x90\x2A\x2A\x2A\x2A\x83\xC4\x10\x84\xC0 as well

Also not correct. Both signatures should be okay.

@sev4a
Copy link

sev4a commented Feb 3, 2023

"Signatures"
{
"CCSGameRules::RewardMatchEndDrops"
{
"library" "server"
"linux" "\x55\x89\xE5\x83\xEC\x58\xA1\x2A\x2A\x2A\x2A\x89\x5D\xF4\x89\x75\xF8\x0F\xB6\x5D\x0C"
"windows" "\x55\x8B\xEC\x83\xE4\xF8\xA1\x2A\x2A\x2A\x2A\x83\xEC\x1C\xB9"
}

@ddorab
Copy link

ddorab commented Feb 3, 2023

am I looking at the wrong binary :/

@Poggicek
Copy link
Contributor

Poggicek commented Feb 3, 2023

"Signatures"
{
"CCSGameRules::RewardMatchEndDrops"
{
"library" "server"
"linux" "\x55\x89\xE5\x83\xEC\x58\xA1\x2A\x2A\x2A\x2A\x89\x5D\xF4\x89\x75\xF8\x0F\xB6\x5D\x0C"
"windows" "\x55\x8B\xEC\x83\xE4\xF8\xA1\x2A\x2A\x2A\x2A\x83\xEC\x1C\xB9"
}

Sourcemod doesn't use this signature. PR to any existing repos using this function instead.

@asherkin
Copy link
Member

asherkin commented Feb 3, 2023

Please take the time to fully consider what you're sharing and be precise about what you're talking about. If you just spam comment as soon as you have a thought this is going to quickly become unreadable - there are no awards for speed here.

Copy link
Member

@asherkin asherkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here everybody!

@asherkin asherkin merged commit a253d35 into alliedmodders:master Feb 3, 2023
StarterX4 pushed a commit to StarterX4/sourcemod that referenced this pull request Aug 1, 2023
SparkyCloudy added a commit to SpectralHive/sourcemod that referenced this pull request Feb 20, 2025
* Fix support for SDKCall returning non-networked entity (alliedmodders#1797)

(cherry picked from commit 625c7a9)

* Update SourcePawn on 1.11-dev.

* Revert "Fix use-after-free when creating custom user messages"

This reverts commit 15450a6.

* Revert "Introduce a pbproxy library to solve macOS linker issues."

This reverts commit e5ddbd9.

* Fix build.

* Update SourcePawn.

* Update gamedata for 2022/10/21 CS:GO update (alliedmodders#1842)

* Trigger build for hl2sdk-csgo update

* Correct missed team offsets in CheckRestartRound (alliedmodders#1844)

* Trigger build for hl2sdk-csgo update

* Fix DHooks jit code stack memory alignment (alliedmodders#1849)

* Enable CI on release branches (alliedmodders#1854)

* Add functions for working with entity lumps (alliedmodders#1673)

* entitylump: Fix behavior of append (alliedmodders#1836)

This change ensures that the iterator values used by `std::distance`
is correct.  Having the emplace within leads to the possibility of
`m_Entities.begin()` being invalidated due to reallocations.

* Update TF2 gamedata.

(cherry picked from commit 89bd4d7)

* Ensure gameconfig file uniqueness when reading master.games (alliedmodders#1859)

The extended gameconfig format reads the master gameconf file twice;
once each for the base engine and actual engine.  The file list
isn't checked for duplicates, so 'common.games.txt' is loaded in
twice, resulting in any 'common' file values potentially overriding
values listed under '#default' in other files due to
bShouldBeReadingDefault.  This happens in the case when matching
game versions by CRC (such as public game branches).

Required for alliedmodders#1857.

(cherry picked from commit 34c8220)

* Trigger build against SDK update

* Trigger build for TF2 SDK update

* entitylump: Output separator as spaces instead of tabs

On NMRiH and possibly other games that use the Maphacks system,
entries that are modified using that system are rendered with tab
characters stripped out - see CNMRiHMapHackManager::GetEntDataString.

That results in there being no separators at all between keys and
values, as Maphacks receives the serialized string from Entity Lump
Manager.

This commit changes the key / value separator character to use
spaces instead.

This discovery upsets me greatly.

Fixes alliedmodders#1833.

* Add missing null pointer check to protobuf messages (alliedmodders#1883)

(cherry picked from commit ef7d3ab)

* Fix ReadMapList ignoring file's last modified time (alliedmodders#1891)

(cherry picked from commit 0d61792)

* Update TF2 gamedata for version 7757534 (2023-01-05) (alliedmodders#1901)

(cherry picked from commit 27b1817)

* Gamedata update after 2/2/2023 CSGO update (alliedmodders#1921)

* Linux [SDKTOOLS] Sigscan for FireOutput FIX (alliedmodders#1923)

Addie said:
test the signatures:
\x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x08
or
digby's \x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x2A\x65\xA1

\x55\x89\xE5\x57\x56\x53\x81\xEC\x8C\x01\x00\x00\x8B\x55\x08 fixed the issue for linux server.

(cherry picked from commit 2dcee81)

* Fix EntityFactoryCaller signature (alliedmodders#1925)

(cherry picked from commit 6e839a9)

* Fix LookupAttachment signature (alliedmodders#1933)

(cherry picked from commit a0eb6a9)

* Enable ShowMenu support for Reactive Drop (see alliedmodders#1938)

Note: Currently only works on beta version of game
(cherry picked from commit 397b70a)

* Fix LookupAttachment signature for NMRiH (alliedmodders#1940)

(cherry picked from commit 693e584)

* Add LookupAttachment signature for ND (alliedmodders#1942)

Adds the LookupAttachment signature for Nuclear Dawn

(cherry picked from commit a9a1939)

* Added hack to make plugins open a menu with all possible targets on ReplyToTargetError COMMAND_TARGET_AMBIGUOUS.
Explanation:
There are two clients in the server, one named gene, the other one "Ene ~special characters~".
An admin issues "sm_slay Ene" and gets following error message: More than one client matched the given pattern.
What this hack will do is: Use GetCmdArg(0, ...); to get the command name "sm_slay".
Use GetCmdArgString(...); to get the arguments supplied to the command.
Use GetLastProcessTargetString(...); (which was implemented in this commit) to retrieve the arguments that were passed to the last ProcessTargetString call.
It will then pass this data to the DynamicTargeting plugin through its AmbiguousMenu native.
The plugin will open up a menu on the client and list all targets which match the pattern that was supplied to ProcessTargetString.
If the client selects a menu entry, FakeClientCommand will be used to re-execute the command with the correct target.

* feat(ci): release tar gz

---------

Co-authored-by: 42 <[email protected]>
Co-authored-by: David Anderson <[email protected]>
Co-authored-by: Vauff <[email protected]>
Co-authored-by: Nick Hastings <[email protected]>
Co-authored-by: Maxim Telezhenko <[email protected]>
Co-authored-by: Erin Baker <[email protected]>
Co-authored-by: nosoop <[email protected]>
Co-authored-by: zer0.k <[email protected]>
Co-authored-by: clague <[email protected]>
Co-authored-by: GAMMACASE <[email protected]>
Co-authored-by: El Diablo <[email protected]>
Co-authored-by: Poggu <[email protected]>
Co-authored-by: Corey D <[email protected]>
Co-authored-by: Dysphie <[email protected]>
Co-authored-by: data-bomb <[email protected]>
Co-authored-by: BotoX <[email protected]>
Co-authored-by: maxime1907 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants