Scan all PT_LOAD segments on Linux for mm_FindPattern#251
Merged
psychonic merged 1 commit intoalliedmodders:masterfrom Jan 4, 2026
Merged
Scan all PT_LOAD segments on Linux for mm_FindPattern#251psychonic merged 1 commit intoalliedmodders:masterfrom
psychonic merged 1 commit intoalliedmodders:masterfrom
Conversation
this matches the behavior of the Windows and macOS implementations which correctly scan the entire module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike in x86 where .rodata might be in the same segment as .text (or at least close enough that PAGE_ALIGN_UP covered it by luck here lol), x64 strictly separates .rodata into its own PF_R only segment. As mm_GetLibraryInfo would only scan the first segment with executable permissions on linux, it would cause mm_FindPattern to miss .rodata in x64
This PR matches the behavior of the Windows and macOS implementations of mm_FindPattern by going over all of the module's PT_LOAD segments instead