Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with flux diff with --path-orig #87

Merged
merged 6 commits into from
Feb 26, 2023
Merged

Fix bug with flux diff with --path-orig #87

merged 6 commits into from
Feb 26, 2023

Conversation

allenporter
Copy link
Owner

@allenporter allenporter commented Feb 26, 2023

Fix bug with flux diff with --path-orig where it was not creating the correct local path for resources, appending the relative path again.

Also adds test that show the issue in #90

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #87 (60e1f73) into main (7f93707) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   92.55%   92.54%   -0.02%     
==========================================
  Files          14       14              
  Lines        1222     1220       -2     
==========================================
- Hits         1131     1129       -2     
  Misses         91       91              
Impacted Files Coverage Δ
flux_local/tool/diff.py 90.59% <85.71%> (-0.16%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@allenporter allenporter merged commit 2e1c4bd into main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants