Skip to content

fix avg_loss rename #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamishivi merged 3 commits into from
Jul 25, 2025
Merged

fix avg_loss rename #828

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73220b3
fix avg_loss rename
garrett361 Jul 25, 2025
1b2c331
Merge branch 'main' into fix-finetuning-reporting
hamishivi Jul 25, 2025
bd76390
Merge branch 'main' into fix-finetuning-reporting
hamishivi Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions open_instruct/finetune.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -905,14 +905,14 @@ def main(args: FlatArguments, tc: TokenizerConfig):
avg_loss = sum_loss / total_fwd_passes
metrics_to_log["train_loss"] = avg_loss
else:
avg_loss_per_total_tok = sum_loss / total_tokens_this_log_period
avg_loss = sum_loss / total_tokens_this_log_period
# The loss per pred tok is the closest analogue to what we report as the
# avg_loss in the "mean" case
avg_loss_per_pred_tok = sum_loss / pred_tokens_this_log_period
total_optim_steps = args.logging_steps * accelerator.num_processes
avg_sum_loss = sum_loss / total_optim_steps
metrics_to_log["train_sum_loss"] = avg_sum_loss
metrics_to_log["train_loss_per_total_tok"] = avg_loss_per_total_tok
metrics_to_log["train_loss_per_total_tok"] = avg_loss
metrics_to_log["train_loss_per_pred_tok"] = avg_loss_per_pred_tok
if args.verbose:
sec_per_step = (time.time() - start_time) / (completed_steps - resume_step)
Expand Down