Skip to content

Fix misnamed variables. #808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finbarrtimbers merged 2 commits into from
Jul 21, 2025
Merged

Fix misnamed variables. #808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e5db0c
Fix misnamed variables.
finbarrtimbers Jul 21, 2025
9b890dc
Ran linter.
finbarrtimbers Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions open_instruct/grpo_fast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1865,7 +1865,7 @@ def maybe_evaluate(
try:
# timeout 0.01 if this is the last training step or we're not evaluating
# otherwise, wait to get the last evaluation generations (long timeout just in case)
timeout = 0.01 if (training_step < args.num_training_steps or args.eval_freq < 0) else 100
timeout = 0.01 if (training_step < args.num_training_steps or args.local_eval_freq < 0) else 100
eval_result = evaluation_inference_results_Q.get(timeout=timeout)

logger.info("[Main Thread] 📊 Evaluation responses received")
Expand Down Expand Up @@ -2102,7 +2102,11 @@ def main(args: Args, tc: TokenizerConfig, model_config: ModelConfig, num_eval_sa
# Start vLLM engines to process from queues
for engine in vllm_engines:
engine.process_from_queue.remote(
generation_config, eval_generation_config, args.eval_freq, args.num_training_steps, resume_training_step
generation_config,
eval_generation_config,
args.local_eval_freq,
args.num_training_steps,
resume_training_step,
)
logger.info("======== ✅ vllm engines started processing from queues =========")

Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.