Write out label_mask instead of labels in olmocore tokenization script #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disable requiring bos for tokenization
add another template, this time w/o im_end
…bug-fix-label-mask
* allow for upsampling of datasets * log dataset-level statistics (# tokens, instances, etc)
hamishivi
reviewed
Jul 21, 2025
…s://github.com/allenai/open-instruct into tyler/olmocore-tokenization-bug-fix-label-mask
hamishivi
approved these changes
Jul 21, 2025
Collaborator
hamishivi
left a comment
hamishivi
left a comment
There was a problem hiding this comment.
Bit hard to see the changes with all the changes from main but I think my main comments got addressed! I see this is merging into the chat template PR so can give that one a look over once this is merged too.
…bug-fix-label-mask
…s://github.com/allenai/open-instruct into tyler/olmocore-tokenization-bug-fix-label-mask
jacob-morrison
deleted the
tyler/olmocore-tokenization-bug-fix-label-mask
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.