Skip to content

Conversation

@garrett361
Copy link
Contributor

This PR proposes two changes to the SFT finetune.py script:

  1. Remove the currently-unused run_name arg
  2. Allow the user to avoid appending the seed and date to the exp_name

For the first point, run_name is never actually used in the script. Instead, it is immediately overwritten by the exp_name value:

args.run_name = f"{args.exp_name}__{args.seed}__{int(time.time())}"

So, I propose removing this no-op arg.

For the second point, it is not always desirable to add the seed and start time to the experiment name. Some reasons:

  1. The date causes the experiment name to change when resuming an experiment.
  2. In multi-node scenarios, the date can be different on each node and the date affects the name of the checkpoint directory, which I believe can cause issues with checkpointing and restart.

@hamishivi hamishivi merged commit dea306f into allenai:main Jul 2, 2025
3 checks passed
@garrett361
Copy link
Contributor Author

Thanks, @hamishivi!

finbarrtimbers pushed a commit that referenced this pull request Jul 2, 2025
finbarrtimbers pushed a commit that referenced this pull request Jul 2, 2025
@fabianlim fabianlim mentioned this pull request Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants