rm run_name, add_seed_and_date_to_exp_name #747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes two changes to the SFT
finetune.pyscript:run_nameargexp_nameFor the first point,
run_nameis never actually used in the script. Instead, it is immediately overwritten by theexp_namevalue:open-instruct/open_instruct/finetune.py
Line 416 in 82632dd
So, I propose removing this no-op arg.
For the second point, it is not always desirable to add the seed and start time to the experiment name. Some reasons: