Update downloads.py

allenai · Jan 5, 2025 · 92adfb6 · 92adfb6
1 parent 2daa80c
commit 92adfb6
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/test/downloads.py b/test/downloads.py
@@ -117,9 +117,11 @@ def _test_download(self, data, download_id):
                 self.skipTest('Test skipped by user')
             except Exception as ex:
                 record['duration'] = time.time() - start
-                record['result'] = 'FAIL' if not data.get('irds_mirror') else 'FAIL_BUT_HAS_MIRROR'
+                has_mirror = 'irds_mirror' in data
+                record['result'] = 'FAIL' if not has_mirror else 'FAIL_BUT_HAS_MIRROR'
                 record['fail_messagae'] = str(ex)
-                raise
+                if not has_mirror:
+                    raise # only raise error if it doesn't have a mirror to avoid spurious errors from the github action
         return record