-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added i) directory support, ii) FP rate args, iii) No-Save option #11
base: main
Are you sure you want to change the base?
Conversation
Oh and some more notes about point 4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens with the progress bar if the output of bff is piped into a file? Or the terminal is in a weird state?
This is why I generally prefer sticking to writing to stdout and stderr, one line at a time, and that's all. It causes the least amount of trouble in unexpected settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggestion. If that's too hard, let's ship it like this.
src/main.rs
Outdated
@@ -609,6 +619,10 @@ fn main() { | |||
let pbar = pbar.clone(); | |||
|
|||
threadpool.execute(move || { | |||
if args.no_progress { | |||
println!("Processing {input:?}..."); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅
Yes will fix this before shipping
src/main.rs
Outdated
&pbar, | ||
args.no_progress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can Arc
pointers be null? Then you could save a parameter and pass in null here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes...? Pretty sure we can wrap with an option and then we don't have to pass the second parameter
… to describe some new features
Several changes to main.rs:
wimbd
).json*.gz
files). Same aswimbd