Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix training Conditional Random Fields on GPU (#5313) #5315

Conversation

alle-pawols
Copy link
Contributor

Fixes #5313 .

Changes proposed in this pull request:

  • Added casting tensor to the proper device

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@AkshitaB AkshitaB requested a review from epwalsh July 16, 2021 16:24
Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alle-pawols, this looks good! Can you just add an entry to the CHANGELOG under the "Fixed" section?

@epwalsh epwalsh self-assigned this Jul 16, 2021
@alle-pawols alle-pawols force-pushed the conditional-random-fileds-doesnt-train-on-the-gpu branch from 0869d08 to 43a0c51 Compare July 19, 2021 09:46
@alle-pawols
Copy link
Contributor Author

@epwalsh I've updated the CHANGELOG file.

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alle-pawols!

@epwalsh epwalsh merged commit 56e1f49 into allenai:main Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConditionalRandomFields doesn't train on the GPU
2 participants