This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
fix race condition when extracting files with cached_path #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkgr
approved these changes
May 26, 2021
| @@ -325,12 +329,24 @@ def cached_path( | |||
|
|
|||
| if extraction_path is not None: | |||
| # If the extracted directory already exists (and is non-empty), then no | |||
| # need to extract again unless `force_extract=True`. | |||
| # need to create a lock file and extract again unless `force_extract=True`. | |||
| if os.path.isdir(extraction_path) and os.listdir(extraction_path) and not force_extract: | |||
| return extraction_path | |||
|
|
|||
| # Extract it. | |||
| with FileLock(extraction_path + ".lock"): | |||
There was a problem hiding this comment.
This will make sure that only one process/thread makes it into the block below, right?
Abhishek-P
pushed a commit
to Abhishek-P/allennlp
that referenced
this pull request
Aug 11, 2021
* fix race condition when extracting files with cached_path * add warning when directory already exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into this when running a T5 experiment on CNN-DM: https://beaker.org/ex/ex_co58l942ntjh/tasks/tk_rd3v6das2fzn.