-
Notifications
You must be signed in to change notification settings - Fork 591
HF dataset loading optimizations #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f4dbde6
Add util methods for loading and saving to disk
2015aroras 82d0e9d
Add logic for loading dataset using disk cache
2015aroras b4acd09
Pass cache dir into downstream evals
2015aroras 561d642
Pass cache dir using training config
2015aroras 9f2d9d2
Simplify, robustify but slightly unoptimize load_dataset logic
2015aroras c55974d
Add type hints for load_dataset
2015aroras 97911fd
Remove type ignore for downstream evaluator construction
2015aroras f934bb7
Re-add type ignore
2015aroras 10737a2
Move load_hf_dataset to utils
2015aroras 2058edd
Add load_hf_dataset tests
2015aroras b5bd9ff
Update CHANGELOG
2015aroras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this
# type: ignore
is probably on the wrong line nowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intellisense puts it there and the type checking passes with it there (and fails without it there).