Make hf_olmo support new transformers versions #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hf_olmoand the OLMo integration intotransformersare not compatible, since both try to register a model from the string "olmo". In particular,hf_olmofails to import. This change makeshf_olmonot register the model & config when the new transformers version is present. Thus:AutoModelForCausalLM.from_pretrained("allenai/OLMo-1B")will work properly as before (ifhf_olmois imported).AutoModelForCausalLM.from_pretrained("allenai/OLMo-1B-hf")will break.AutoModelForCausalLM.from_pretrained("allenai/OLMo-1B")will break (none of the weights will get loaded).AutoModelForCausalLM.from_pretrained("allenai/OLMo-1B-hf")will work properly. UsingOLMoForCausalLM.from_pretrained("allenai/OLMo-1B")withOLMoForCausalLMfromhf_olmowill work just like in old versions.