Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HF pipeline test failure #534

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

2015aroras
Copy link
Collaborator

@2015aroras 2015aroras commented Apr 2, 2024

Upgrading to transformers 4.39.1 caused a HF pipeline test to start failing (e.g. https://github.com/allenai/OLMo/actions/runs/8444118035/job/23129075811). The issue is a HF bug (huggingface/transformers#29426) and this is a workaround to get around the problem.

@2015aroras 2015aroras marked this pull request as ready for review April 2, 2024 00:22
@2015aroras 2015aroras changed the title Add cache_position dummy parameter to ignore faulty input Fix HF pipeline test failure Apr 2, 2024
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised this doesn't fail some check for an unused parameter?

@2015aroras
Copy link
Collaborator Author

Surprised this doesn't fail some check for an unused parameter?

It causes a linting warning. It can be valid when implementing an inherited method without needing all the parameters. I assume this is why it doesn't cause an error.

@2015aroras 2015aroras merged commit 8fad649 into main Apr 2, 2024
11 checks passed
@2015aroras 2015aroras deleted the shanea/fix-transformer-cache-position-regression branch April 2, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants