GQA into Mitchich65 #443
Merged
GQA into Mitchich65 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down what you fucking mean?
Updates to 70B config and checkpointing
dirkgr
commented
Mar 18, 2024
| @@ -1047,6 +1049,11 @@ class TrainConfig(BaseConfig): | |||
| The activation checkpointing strategy to use. | |||
| """ | |||
|
|
|||
| fused_loss: Optional[bool] = None | |||
| """ | |||
| Whether to use the fused CE loss function from `flash-attn`. | |||
olmo/eval/evaluator.py
Outdated
Comment on lines
59
to
60
| out[f"eval/ppl/{label}/CrossEntropyLoss"] = loss.item() | ||
| out[f"eval/ppl/{label}/Perplexity"] = torch.exp(loss).item() |
There was a problem hiding this comment.
This will make comparisons impossible?
There was a problem hiding this comment.
Hmm yea could be difficult. It just annoys me these aren't grouped together in W&B. Reverted: 856860d
| try: | ||
| mp.set_start_method("spawn", force=True) | ||
| except RuntimeError as e: | ||
| print(f"failed to set multiprocessing start method: {e}") |
There was a problem hiding this comment.
I did not know this could fail?
There was a problem hiding this comment.
Yea I saw this happen a couple times, not sure why exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO