[Storage cleaner] Improve handling of temp directories and files #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwalsh
approved these changes
Dec 11, 2023
scripts/storage_cleaner.py
Outdated
| @@ -729,6 +733,11 @@ def delete_bad_runs(run_paths: List[str], config: DeleteBadRunsConfig): | |||
| log.info("Starting to check if run %s should be deleted", run_path) | |||
| _delete_if_bad_run(storage, run_path, config) | |||
|
|
|||
| # Delete temp dir after each run to avoid memory bloat | |||
There was a problem hiding this comment.
Suggested change
| # Delete temp dir after each run to avoid memory bloat | |
| # Delete temp dir after each run to avoid storage bloat |
scripts/storage_cleaner.py
Outdated
Comment on lines
1000
to
1002
| if Path(temp_dir).is_dir(): | ||
| log.info("Deleting temp dir %s", temp_dir) | ||
| shutil.rmtree(temp_dir) |
There was a problem hiding this comment.
This should probably run even if the cleaning op fails, so you might want to add a try: ... finally: ... block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation has a few issues with respect to temp directories and files. Below I list the issues and their corresponding fixes in this PR.
Operations do not delete all the temp content (e.g. unarchived directories) added to the user-provided temp directory.
Handle temporary directory creation and completion in
perform_operation, which is shared by all operations.Bad run deletion can take several runs as input, so the number of uncleaned artifacts can easily grow.
Added temp directory cleanup after each run.
The unsharding temp directory is not under the user-provided temp directory.
Changed unsharding temp directory creation to fix this.
The majority of the additions/deletions were caused from moving
perform_operationdown the file (77c648a).