Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check this field is set first #21

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Check this field is set first #21

merged 1 commit into from
Dec 25, 2020

Conversation

specialtactics
Copy link
Contributor

@specialtactics specialtactics commented Dec 25, 2020

I was updating some VCR files, and I noticed we had this problem occur:

ErrorException: Undefined index: request_header

/var/www/vendor/allejo/php-vcr-sanitizer/src/VCRCleanerEventSubscriber.php:199
/var/www/vendor/allejo/php-vcr-sanitizer/src/VCRCleanerEventSubscriber.php:58
/var/www/vendor/symfony/event-dispatcher/EventDispatcher.php:230
/var/www/vendor/symfony/event-dispatcher/EventDispatcher.php:59
/var/www/vendor/php-vcr/php-vcr/src/VCR/Videorecorder.php:106

It may be related to the fact that we updated all packages very recently.

So I had a look, and making the change in this PR fixed the issue for us. I also did a dump of the curl info in $workspace to make sure it is actually set in general, and everything else looked fine.

@allejo allejo merged commit a0ee00e into allejo:master Dec 25, 2020
@allejo
Copy link
Owner

allejo commented Dec 25, 2020

Thanks @specialtactics! I've tagged v1.0.8 with this patch 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants