Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to remove non-expired data #317

Merged
merged 2 commits into from
May 9, 2022
Merged

Fix bug to remove non-expired data #317

merged 2 commits into from
May 9, 2022

Conversation

1xxz188
Copy link
Contributor

@1xxz188 1xxz188 commented May 7, 2022

Sometimes an error occurs to remove non-expired data when "currentTimestamp" is less than "oldestTimestamp"

@1xxz188 1xxz188 requested review from janisz and cristaloleg as code owners May 7, 2022 03:23
rename TestRemoveNonExpiredData and Remove Chinese comments
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #317 (111404c) into master (bec16b0) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   88.78%   88.97%   +0.18%     
==========================================
  Files          15       15              
  Lines         767      771       +4     
==========================================
+ Hits          681      686       +5     
  Misses         72       72              
+ Partials       14       13       -1     
Impacted Files Coverage Δ
bigcache.go 96.63% <100.00%> (-2.51%) ⬇️
shard.go 88.58% <100.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec16b0...111404c. Read the comment docs.

@janisz janisz added the bug label May 9, 2022
@janisz janisz merged commit 0b306aa into allegro:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants