test: convert the example in issue #300 into a test case #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new commit-id 16df11e can fix the issue
|
@janisz |
janisz
reviewed
Nov 18, 2021
bigcache_test.go
Outdated
| MaxEntrySize: 52, | ||
| }) | ||
| cache.Set("a", blob(0xff, 235)) | ||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
We should not sleep in tests. Please use mockedClock
There was a problem hiding this comment.
I replaced time.Sleep with mockedClock.Please take a look
janisz
reviewed
Nov 19, 2021
|
@contestjia Coul you fix formatting to pass linter? |
|
@janisz yes, i fixed |
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 88.78% 89.30% +0.52%
==========================================
Files 15 15
Lines 767 767
==========================================
+ Hits 681 685 +4
+ Misses 72 69 -3
+ Partials 14 13 -1
Continue to review full report at Codecov.
|
janisz
previously approved these changes
Dec 2, 2021
janisz
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new commit-id 16df11e can fix the issue