Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HardMaxCacheSize documentation #298

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

hanshuhuang
Copy link
Contributor

As #292 has pointed out, the documentation has misleading message for HardMaxCacheSize.

To solve it, this PR modifies the HardMaxCacheSize comment.

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #298 (6ee2fde) into master (74e2db1) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   88.97%   88.45%   -0.53%     
==========================================
  Files          15       15              
  Lines         762      762              
==========================================
- Hits          678      674       -4     
- Misses         70       73       +3     
- Partials       14       15       +1     
Impacted Files Coverage Δ
config.go 100.00% <ø> (ø)
shard.go 86.90% <0.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e2db1...6ee2fde. Read the comment docs.

@janisz janisz merged commit 0c76355 into allegro:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants