-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: panic runtime error: index out of range [7] with length 0 #288
Conversation
场景见: bigcache_test.go#TestCache_RepeatedSetWithBiggerEntry
@cristaloleg @bgalek Can you take a look at this? |
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 86.52% 88.99% +2.47%
==========================================
Files 15 15
Lines 638 763 +125
==========================================
+ Hits 552 679 +127
+ Misses 71 70 -1
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
@blackbeans Looks like tests are failing |
i resubmit . TestCase should use t.Logf to print error ,not use t.Error |
@cristaloleg PTAL |
Please merge this pull request earlier. |
@cristaloleg can you merge it? I have no permission to do that's :( |
Could you please cut a bugfix release? Thanks! |
Oh, our plugin for releases is not trusted :(
|
issue : #283