Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.16 #271

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Update Go to 1.16 #271

merged 2 commits into from
Apr 21, 2021

Conversation

janisz
Copy link
Collaborator

@janisz janisz commented Mar 1, 2021

cristaloleg
cristaloleg previously approved these changes Mar 1, 2021
@cristaloleg
Copy link
Collaborator

hehe https://github.com/allegro/bigcache/pull/271/checks?check_run_id=2004711937#step:5:21

> there's no need to use reflect package and its headers because direct cast already creates new header as a result:

https://stackoverflow.com/a/59817335/1387612
@janisz
Copy link
Collaborator Author

janisz commented Mar 9, 2021

@cristaloleg Ping

@cristaloleg
Copy link
Collaborator

I'm not able to click Merge due to handing Build 1.13.x. To fix this I need a higher permission lvl, kindly pinging @adamdubiel :)

@bgalek
Copy link
Member

bgalek commented Apr 21, 2021

LGTM!

@bgalek bgalek merged commit d8e8052 into allegro:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants