inital prep for v3. #245
Closed
inital prep for v3. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Lloyd <[email protected]>
* Fix iterator styling issues (#247) Issues reported in #246 * fix #160 (#246) * Update to latest golang (#248) Co-authored-by: Oleg Kovalov <[email protected]> * inital prep for v3. Signed-off-by: Mike Lloyd <[email protected]> * Use uint64 intead of uint32 There are posibility we run into a problem of int32 overflow. To prevent this let's use uint64 everywhere. https://github.com/allegro/bigcache/blob/21e5ca5c3d539f94e8dc563350acd97c5400154f/shard.go#L138 Fixes: #148 * Fix CI * Do not run on 1.13 * Do not run long test * Optimze append (#249) * Add Benchmark for append * Optimize Append and halve byte copies * Optimize Append by reducing allocs * Optimize Append by reducing allocs * Reduces allocs from test construct Co-authored-by: Fabian Gärtner <[email protected]> Co-authored-by: S@P <[email protected]> Co-authored-by: Oleg Kovalov <[email protected]> Co-authored-by: Mike Lloyd <[email protected]> Co-authored-by: Fabianexe <[email protected]> Co-authored-by: Fabian Gärtner <[email protected]>
siennathesane
force-pushed
the
versions/v3-prep
branch
from
64eb605 to
b548fed
Compare
Signed-off-by: Mike Lloyd <[email protected]>
|
@janisz can you take a look at the build problems for me? My knowledge of go modules is weak and I can't figure out the problem. |
janisz
reviewed
Nov 4, 2020
go.mod
Outdated
|
|
||
| go 1.12 | ||
|
|
||
| require github.com/allegro/bigcache/v3 v3.0.0 |
janisz
reviewed
Nov 4, 2020
go.sum
Outdated
| @@ -0,0 +1,3 @@ | |||
| github.com/allegro/bigcache v1.2.1 h1:hg1sY1raCwic3Vnsvje6TT7/pnZba83LeFck5NrFKSc= | |||
| github.com/allegro/bigcache/v2 v2.2.5 h1:mRc8r6GQjuJsmSKQNPsR5jQVXc8IJ1xsW5YXUYMLfqI= | |||
| github.com/allegro/bigcache/v2 v2.2.5/go.mod h1:FppZsIO+IZk7gCuj5FiIDHGygD9xvWQcqg1uIPMb6tY= | |||
diff --git a/examples_test.go b/examples_test.go
index f447072..ccc513a 100644
--- a/examples_test.go
+++ b/examples_test.go
@@ -5,7 +5,7 @@ import (
"log"
"time"
- "github.com/allegro/bigcache/v2"
+ "github.com/allegro/bigcache/v3"
)
func Example() {
diff --git a/go.mod b/go.mod
index 6f045f2..8be47fa 100644
--- a/go.mod
+++ b/go.mod
@@ -1,5 +1,3 @@
module github.com/allegro/bigcache/v3
go 1.12
-
-require github.com/allegro/bigcache/v2 v2.2.5
diff --git a/go.sum b/go.sum
index fdc2c46..e69de29 100644
--- a/go.sum
+++ b/go.sum
@@ -1,3 +0,0 @@
-github.com/allegro/bigcache v1.2.1 h1:hg1sY1raCwic3Vnsvje6TT7/pnZba83LeFck5NrFKSc=
-github.com/allegro/bigcache/v2 v2.2.5 h1:mRc8r6GQjuJsmSKQNPsR5jQVXc8IJ1xsW5YXUYMLfqI=
-github.com/allegro/bigcache/v2 v2.2.5/go.mod h1:FppZsIO+IZk7gCuj5FiIDHGygD9xvWQcqg1uIPMb6tY= |
Merged
|
It looks like we have a flaky test |
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 86.56% 87.20% +0.64%
==========================================
Files 15 15
Lines 640 641 +1
==========================================
+ Hits 554 559 +5
+ Misses 71 68 -3
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
|
@cristaloleg and @janisz I'm working on the interface definition for #204 via 34853d0, do we want to cut 3.0 with just the interface then add in a new default implementation in 3.1? I want to get the interface definition with 3.0, but I don't want the release to be held back on the initial implementation since this fixes #148. |
|
IMO we should release this and add new features in feature release. Still I'm not sure if we lost backward compatibility. Do we really need 3.0 release? |
I'm not either but better to be safe than sorry. |
* Go defaults to "0"" so in case we want to return EntryStatus back to the caller "Expired" cannot be differentiated. Fixing this by default "_" to 0 and incremental RemoveReasons comment was missing for GetWithInfo api so updated that test: ran all unit test cases * Entry RemoveReason is iota based with default value being 0 Currently all const for RemovedReason are explicitly set to avoid any breaking changes. For v3 migrating the reasons to iota makes code readability and managing addition of more reasons easier in the future. Test: Validated all test cases run successfully. Co-authored-by: Mike Lloyd <[email protected]> Co-authored-by: jgheewala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the base branch to make progress on the v3 work and start getting things in place.
Signed-off-by: Mike Lloyd [email protected]